turbot / steampipe-export

Steampipe Export is a zero-ETL CLI to fetch data from cloud services and APIs. Hundreds of plugins with thousands of documented examples.
https://steampipe.io
Apache License 2.0
8 stars 1 forks source link

module declares its path as: steampipe-plugin-mastodon but was required as: github.com/turbot/steampipe-plugin-mastodon #14

Closed judell closed 11 months ago

judell commented 11 months ago

make build plugin=mastodon go run generate/generator.go templates . mastodon 4 filePath: /home/jon/steampipe-table-dump/templates not a file, continuing...

filePath: /home/jon/steampipe-table-dump/templates/.goreleaser.yml.tmpl filePath: /home/jon/steampipe-table-dump/templates/main.go.tmpl filePath: /home/jon/steampipe-table-dump/templates/out not a file, continuing...

filePath: /home/jon/steampipe-table-dump/templates/out/Makefile.tmpl filePath: /home/jon/steampipe-table-dump/templates/out/README.md.tmpl go mod tidy go: finding module for package github.com/turbot/steampipe-plugin-mastodon/mastodon go: downloading github.com/turbot/steampipe-plugin-mastodon v0.1.1 go: found github.com/turbot/steampipe-plugin-mastodon/mastodon in github.com/turbot/steampipe-plugin-mastodon v0.1.1 go: github.com/turbot/steampipe-table-dump imports github.com/turbot/steampipe-plugin-mastodon/mastodon: github.com/turbot/steampipe-plugin-mastodon@v0.1.1: parsing go.mod: module declares its path as: steampipe-plugin-mastodon but was required as: github.com/turbot/steampipe-plugin-mastodon make: *** [Makefile:9: build] Error 1

pskrbasu commented 11 months ago

@judell It seems that the package mastodon is not available.

Screenshot 2023-11-22 at 5 56 47 PM

judell commented 11 months ago

https://github.com/turbot/steampipe-plugin-mastodon definitely exists, and can be built standalone

It is as the message says. In go.mod:

module steampipe-plugin-mastodon

in main.go

package main

import (
        "steampipe-plugin-mastodon/mastodon"

        "github.com/turbot/steampipe-plugin-sdk/v5/plugin"
)

This doesn't affect the normal build but evidently does affect the table-dump build.

I don't know why the pattern for mastodon differs from, e.g., github.

module github.com/turbot/steampipe-plugin-github

package main

import (
        "github.com/turbot/steampipe-plugin-github/github"
        "github.com/turbot/steampipe-plugin-sdk/v5/plugin"
)

Maybe @misraved can help?

judell commented 11 months ago

Ved Misra 9:22 AM first observation - the issue is not only confined to mastodon, but a host of other plugins as well

Jon Udell 9:23 AM Yeah that's what I was wondering about, 9:23 We should move this to the issue discussion though.

Ved Misra 9:23 AM yes

judell commented 11 months ago

@misraved I just needed to do this in go.mod

module github.com/turbot/steampipe-plugin-mastodon

and this in

import (
        "github.com/turbot/steampipe-plugin-mastodon/mastodon"

        "github.com/turbot/steampipe-plugin-sdk/v5/plugin"
)

I've made the update here, https://github.com/turbot/steampipe-plugin-mastodon/pull/34, and it could be done in main as well if we wind up not shipping that branch.

What about the other cases you mentioned, though. Should we list them here as items to complete in order to close this issue?

pskrbasu commented 11 months ago

Resolved