search

turbot / steampipe-mod-aws-compliance

Run individual controls or full compliance benchmarks for CIS, PCI, NIST, HIPAA and more across all of your AWS accounts using Powerpipe and Steampipe.
https://hub.steampipe.io/mods/turbot/aws_compliance
Apache License 2.0
372 stars 63 forks source link

Query vpc_security_group_associated.sql should address distinct clause to filter vpc security groups. #282

Closed rajlearner17 closed 3 years ago

rajlearner17 commented 3 years ago

Is your feature request related to a problem? Please describe.

vpc_security_group_associated.sql is used in the following places

  1. pci_v321_ec2_3 > Unused EC2 security groups should be removed > Query should contain distinct to avoid duplicate data. 2.nist_csf_pr_ds_3 > control.vpc_security_group_associated - Though the purpose of the query satisfies the outcome, however, the title VPC security groups should be associated with at least one ENI does not match the reason. This should be associated with a new query file. (New query file change should be in conformance_pack/vpc.sp, nist_csf/function_pr.sp)

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

misraved commented 3 years ago

Closed as a part of - https://github.com/turbot/steampipe-mod-aws-compliance/pull/283 PR