Fix for untagged "is null" check not finding all cases of untagged resources

turbot / steampipe-mod-aws-tags

Is your AWS tagging strategy following best practice? This mod checks if your AWS resource tags are set correctly to help you manage them effectively using Powerpipe and Steampipe.

https://hub.powerpipe.io/mods/turbot/aws_tags

Apache License 2.0

19 stars 8 forks source link

Fix for untagged "is null" check not finding all cases of untagged resources #37

Closed brad-webb closed 1 year ago

brad-webb commented 1 year ago

Checking tags object for is_null is not always sufficient to find resources with no tags.

This commit adds an additional check for keys in the tags object.

Use of SELECT sub-query on jsonb_object_keys(tags) is consistent with use found in:

limit.sp: Ln 13
mandatory.sp: Ln 14
prohibited.sp: Ln 19

Checklist

[- [ ] Issue(s) linked] https://github.com/turbot/steampipe-mod-aws-tags/issues/36

cbruno10 commented 1 year ago

Thanks @brad-webb for the testing and PR! We'll release this with some other upcoming changes next week most likely.