search

turbot / steampipe-mod-aws-thrifty

Are you a Thrifty AWS dev? This mod checks your AWS accounts for unused and under-utilized resources using Powerpipe and Steampipe.
https://hub.powerpipe.io/mods/turbot/aws_thrifty
Apache License 2.0
98 stars 18 forks source link

Remove comments from the inline query of `vpc_nat_gateway_unused` control #125

Closed misraved closed 1 year ago

misraved commented 1 year ago

Describe the bug Because of the comments -- Required Columns and -- Additional Dimensions in vpc_nat_gateway_unused control's inline query, the output format of the query on the hub is broken.

https://github.com/turbot/steampipe-mod-aws-thrifty/blob/eb46115f28a81a9b220a3169889783e2fde0ba46/controls/network.sp#L67

https://hub.steampipe.io/mods/turbot/aws_thrifty/controls/control.vpc_nat_gateway_unused?context=benchmark.network#sql

Steampipe version (steampipe -v) Example: v0.20.0-alpha.1

Plugin version (steampipe plugin list) Example: v0.5.0

To reproduce https://hub.steampipe.io/mods/turbot/aws_thrifty/controls/control.vpc_nat_gateway_unused?context=benchmark.network#sql

Expected behavior The query should adhere to https://hub.steampipe.io/mods/turbot/aws_thrifty/controls/control.vpc_nat_gateway_unused?context=benchmark.network#sql format

Additional context Add any other context about the problem here.

misraved commented 1 year ago

Addressed in https://github.com/turbot/steampipe-mod-aws-thrifty/pull/126