search

turbot / steampipe-mod-kubernetes-compliance

Run individual controls or full compliance benchmarks for NSA CISA Kubernetes Hardening Guidance across all of your Kubernetes clusters using Powerpipe and Steampipe.
https://hub.powerpipe.io/mods/turbot/kubernetes_compliance
Apache License 2.0
32 stars 4 forks source link

Controls should reference their query using `query =` rather than `sql =` #22

Closed e-gineer closed 1 year ago

e-gineer commented 1 year ago

It's simpler in code and readability to reference queries using the query = attribute rather than the sql = attribute.

This occurs throughout the mod, but as a specific example:

https://github.com/turbot/steampipe-mod-kubernetes-compliance/blob/c535281192b9f0dc92eabe7d360b39e95e9c84b6/cis_kube_v120/cis_kube_v120_v100.sp#L188-L200

Could be changed from:

  sql           = query.pod_security_policy_container_privilege_escalation_disabled.sql

to:

  query         = query.pod_security_policy_container_privilege_escalation_disabled
github-actions[bot] commented 1 year ago

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

github-actions[bot] commented 1 year ago

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

khushboo9024 commented 1 year ago

Completed as per https://github.com/turbot/steampipe-mod-kubernetes-compliance/pull/28