search

turbot / steampipe-mod-oci-compliance

Run individual configuration, compliance and security controls or full compliance benchmarks for CIS across all of your Oracle Cloud Infrastructure accounts using Powerpipe and Steampipe.
https://hub.powerpipe.io/mods/turbot/oci_compliance
Apache License 2.0
4 stars 1 forks source link

Controls should reference their query using `query =` rather than `sql =` #57

Closed madhushreeray30 closed 1 year ago

madhushreeray30 commented 1 year ago

It's simpler in code and readability to reference queries using the query = attribute rather than the sql = attribute.

This occurs throughout the mod, but as a specific example:

https://github.com/turbot/steampipe-mod-oci-compliance/blob/12beca96d5af01733cd080a18fb3e63474a4e178/cis_v110/section_1.sp#L83-L95

Could be changed from:

sql           = query.identity_user_customer_secret_key_age_90.sql

to:

query         = query.identity_user_customer_secret_key_age_90
github-actions[bot] commented 1 year ago

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

misraved commented 1 year ago

Closed as a part of https://github.com/turbot/steampipe-mod-oci-compliance/pull/58