search

turbot / steampipe-mod-terraform-aws-compliance

Run compliance and security controls to detect Terraform AWS resources deviating from security best practices prior to deployment using Powerpipe and Steampipe.
https://hub.powerpipe.io/mods/turbot/terraform_aws_compliance
Apache License 2.0
24 stars 3 forks source link

Controls should reference their query using `query = ` rather than `sql =` #46

Closed madhushreeray30 closed 1 year ago

madhushreeray30 commented 1 year ago

It's simpler in code and readability to reference queries using the query = attribute rather than the sql = attribute.

This occurs throughout the mod, but as a specific example:

https://github.com/turbot/steampipe-mod-terraform-aws-compliance/blob/96ccc54260d8ef443b354dc23bf20b41548af76c/controls/athena.sp#L21-L28

Could be changed from:

sql           = query.athena_database_encryption_at_rest_enabled.sql

to:

query         = query.athena_database_encryption_at_rest_enabled
github-actions[bot] commented 1 year ago

'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 90 days with no activity.