turbot / steampipe-plugin-aws

Use SQL to instantly query AWS resources across regions and accounts. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/aws
Apache License 2.0
177 stars 89 forks source link

Fixed the operation not allowed error for the table aws_directory_service_directory Closes #2155 #2170

Closed ParthaI closed 2 months ago

ParthaI commented 2 months ago

Integration test logs

Logs ``` N/A ```

Example query results

Results ``` Before fix: > select name, type, event_topics, snapshot_limit from aws_directory_service_directory Error: aws: operation error Directory Service: GetSnapshotLimits, https response error StatusCode: 400, RequestID: b75299bd-9b0c-4818-9609-e61aba43c002, ClientException: Snapshot limits can be fetched only for VPC or Microsoft AD directories. : RequestId: b75299bd-9b0c-4818-9609-e61aba43c002 (SQLSTATE HV000) +----------+----------+--------------+------------------------------------------------------------------------------------------------+ | name | type | event_topics | snapshot_limit | +----------+----------+--------------+------------------------------------------------------------------------------------------------+ | test.com | SimpleAD | [] | {"ManualSnapshotsCurrentCount":0,"ManualSnapshotsLimit":5,"ManualSnapshotsLimitReached":false} | +----------+----------+--------------+------------------------------------------------------------------------------------------------+ After fix: > select name, type, event_topics, snapshot_limit from aws_directory_service_directory +----------+-------------+--------------+------------------------------------------------------------------------------------------------+ | name | type | event_topics | snapshot_limit | +----------+-------------+--------------+------------------------------------------------------------------------------------------------+ | test.com | ADConnector | [] | | | test.com | SimpleAD | [] | {"ManualSnapshotsCurrentCount":0,"ManualSnapshotsLimit":5,"ManualSnapshotsLimitReached":false} | +----------+-------------+--------------+------------------------------------------------------------------------------------------------+ ```