search

turbot / steampipe-plugin-aws

Use SQL to instantly query AWS resources across regions and accounts. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/aws
Apache License 2.0
188 stars 100 forks source link

Add aws_route53_vpc_association_authorization table #2199

Closed jramosf closed 3 months ago

jramosf commented 4 months ago

Integration test logs

Included in PR

Example SQLs

``` > select auth.hosted_zone_id, z.name, auth.vpc_id, auth.vpc_region from aws_route53_vpc_association_authorization auth inner join aws_route53_zone z on auth.hosted_zone_id = z.id where z.name = 'mycooldomain.xyz.'; +-----------------------+-------------------+-----------------------+--------------+ | hosted_zone_id | name | vpc_id | vpc_region | +-----------------------+-------------------+-----------------------+--------------+ | Z0000FDFF7ABCB5300DCD | mycooldomain.xyz. | vpc-528a4593d487ae210 | us-west-2 | | Z0000FDFF7ABCB5300DCD | mycooldomain.xyz. | vpc-d5ad858e2fdcd1b82 | us-west-2 | | Z0000FDFF7ABCB5300DCD | mycooldomain.xyz. | vpc-a178b46b045f372aa | us-east-2 | | Z0000FDFF7ABCB5300DCD | mycooldomain.xyz. | vpc-4dc00a30a2e9bdbba | eu-central-1 | +-----------------------+-------------------+-----------------------+--------------+ ```

I've reached out to AWS to see if there's a possibility to get the VPC owning account ID in https://docs.aws.amazon.com/Route53/latest/APIReference/API_ListVPCAssociationAuthorizations.html or https://docs.aws.amazon.com/Route53/latest/APIReference/API_ListHostedZones.html API calls, if they end up adding the field it I'll add another PR as follow-up.

jramosf commented 3 months ago

@ParthaI @misraved any chance this gets merged? Thanks!

ParthaI commented 3 months ago

Hi @jramosf,

I apologize for the delay in the review process. Your PR is on my list, and I will be reviewing it today. I will let you know if any changes are needed. Thank you for your patience!

jramosf commented 3 months ago

Hi @ParthaI , thanks for the review. I've made the suggested changes.

jramosf commented 3 months ago

Added modifications in https://github.com/turbot/steampipe-plugin-aws/compare/075635ca3412e5b574a3e1d4b9aa0341a232a84a..123e98b52875d5fb6b51f67bb34e97c99c9d2ae7

jramosf commented 3 months ago

Hi @ParthaI , I can't see any more comments, is this done already?

ParthaI commented 3 months ago

Apologies, @jramosf, this might have been placed incorrectly. I have already approved the PR.

jramosf commented 3 months ago

Thanks!. I am not authorized to merge in this repo but I assume I'm now finished with this PR and you'll merge it for next release. Cheers

jramosf commented 3 months ago

Added changes, hopefully this get merged after so many reviews... For just this simple table

Thanks

misraved commented 3 months ago

The changes look good @jramosf, thank you so much for making the new table 👍.