search

turbot / steampipe-plugin-azuread

Use SQL to instantly query groups, service principals, users and more from Azure Active Directory. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/azuread
Apache License 2.0
7 stars 12 forks source link

chore: update all microsoft, microsoftgraph and Azure SDKs #166

Closed pdecat closed 11 months ago

pdecat commented 11 months ago

This PR tentatively upgrades all MS and Azure SDKs, expectations are to resolves issues with AZURECHINACLOUD environment.

Marked as draft as testing is currently in progress.

ParthaI commented 11 months ago

Thank you, @pdecat, for your contribution to Steampipe.

There's an existing pull request (PR) that updates the Azure SDK version and the MS Graph SDK version. Would you kindly test it to see if it resolves issues related to the AZURECHINACLOUD environment?

Furthermore, this PR includes a fix for the error:

Error: {"Code":"","Message":"received a claim for CAE but azure identity doesn't support claims: {\"access_token\":{\"nbf\":{\"essential\":true,\"value\":\"1700823904\"},\"xms_rp_ipaddr\":{\"value\":\"REDACTED\"}}}

Related discussion: https://github.com/turbot/steampipe-plugin-azuread/issues/150#issuecomment-1825957667

Thanks!

pdecat commented 11 months ago

Hi @ParthaI!

Oh, too bad I missed your PR :facepalm: I just happened to be testing many changes for a colleague that is facing errors when environment = "AZURECHINACLOUD" is set in his configuration, and in the end thought I'll open a PR with those changes.

Anyway, none of these changes resolve the errors, I asked him to open a Github issue. Edit: https://github.com/turbot/steampipe-plugin-azuread/issues/167