Closed marcus-crane closed 2 years ago
@LalitTurbot Heya, just wanted to bump this PR since it's been ready for review for some time ๐
Hey @marcus-crane , sorry for the very long delay on reviewing, we missed a few open PRs recently, but are circling back on them. We'll have a few done in the next few days.
Thanks again for opening this PR!
'This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'
Ah, hey! Sorry, I hadn't gotten back to addressing your feedback but I hadn't forgotten ๐ It's been a while so I've forgotten some details but I'm happy to open another PR with improvements down the line ๐
Tables added
Closes: #19
This is my first steampipe contribution so I expect I might have overlooked some things but I've tried to adhere to the style of the existing tables where possible.
There are a few things worth pointing out:
up
to false. If Steampipe removes an entry from the table upon trying to rehydrate it and getting a 404, then this isn't such a big deal but either way, it kind of makes theup
field redundant if it is always set totrue
host_name
, which is available in the hosts API, as it appears to contain the exact same data asname
based on the description.Anyway, I didn't worry too much about the edge cases since they can be ironed out over time I'm sure.
You can do quite a lot of fun queries by making use of
jsonb
which I've heard about for a few years now but I've never actually seen it in action before now.