turbot / steampipe-plugin-datadog

Use SQL to instantly query Datadog resources across accounts. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/datadog
Apache License 2.0
12 stars 5 forks source link

Add table for `datadog_host` #20

Closed marcus-crane closed 2 years ago

marcus-crane commented 2 years ago

Tables added

+------------------------------------+-------------------------------------------------------------------------------------------------------------------------+
| table                              | description                                                                                                             |
+------------------------------------+-------------------------------------------------------------------------------------------------------------------------+
| datadog_host                       | A host is any piece of infrastructure that runs an instance of the Datadog Agent such as a bare metal instance or a VM. |
+------------------------------------+-------------------------------------------------------------------------------------------------------------------------+

Closes: #19

This is my first steampipe contribution so I expect I might have overlooked some things but I've tried to adhere to the style of the existing tables where possible.

There are a few things worth pointing out:

Anyway, I didn't worry too much about the edge cases since they can be ironed out over time I'm sure.

You can do quite a lot of fun queries by making use of jsonb which I've heard about for a few years now but I've never actually seen it in action before now.

CleanShot 2022-07-23 at 17 49 34@2x
marcus-crane commented 2 years ago

@LalitTurbot Heya, just wanted to bump this PR since it's been ready for review for some time ๐Ÿ˜…

cbruno10 commented 2 years ago

Hey @marcus-crane , sorry for the very long delay on reviewing, we missed a few open PRs recently, but are circling back on them. We'll have a few done in the next few days.

Thanks again for opening this PR!

github-actions[bot] commented 2 years ago

'This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

marcus-crane commented 2 years ago

Ah, hey! Sorry, I hadn't gotten back to addressing your feedback but I hadn't forgotten ๐Ÿ˜… It's been a while so I've forgotten some details but I'm happy to open another PR with improvements down the line ๐Ÿ˜€