search

turbot / steampipe-plugin-gcp

Use SQL to instantly query GCP resources across regions, projects and organizations. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/gcp
Apache License 2.0
39 stars 24 forks source link

Gcp cloud functions gen2 flooding #590

Closed ashutoshmore658 closed 1 week ago

ashutoshmore658 commented 1 month ago

Fixes https://github.com/turbot/steampipe-plugin-gcp/issues/579 issue

ashutoshmore658 commented 1 month ago

@ParthaI sure, let me take a look at this. Thank you for the valuable feedback. also let me do a POC with the changes you are suggesting, because before going this way I tried with your approach but it was populating null values for these columns. So I decided to code by this way.

ashutoshmore658 commented 1 month ago

@ParthaI actually I have tried by modifying code, checked with multiple times restarting the system(to avoid cached builds), I am getting null for the columns, it is working for the status only. please have a look at the following test screenshot Screenshot from 2024-06-02 03-47-48

ParthaI commented 1 month ago

Hello, @ashutoshmore658, I am not sure what the issue is with your system. I can see the result for all of the columns as mentioned here.

Screenshot 2024-06-03 at 10 40 42 AM

Note: I have renamed the column environment_variables to service_environment_variables to distinguish between the two types of environment variables: one for build and one for service. I am not retrieving the build_environment_variables because I have not configured it.

I have pushed the tested code to the branch test-gcp-cloud-function-table-column. Please feel free to take a look.

Thanks!

ashutoshmore658 commented 1 month ago

Sure @ParthaI , I will test and lets merge it if it looks fine and okay to merge.

ParthaI commented 4 weeks ago

Hi @ashutoshmore658, Did you get a chance to retake a look at it?