turbot / steampipe-plugin-godaddy

Use SQL to instantly query GoDaddy resources. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/godaddy
Apache License 2.0
2 stars 0 forks source link

Add initial GoDaddy tables Closes #1 #2

Closed rajlearner17 closed 1 year ago

misraved commented 1 year ago

@ParthaI @rajlearner17 I see a total of 10 APIs that can be used to create the tables in - https://developer.godaddy.com/doc

Is there any specific reason why we didn't add other tables?

misraved commented 1 year ago

Questions around environment_type and other config arguments -

  1. What is the reason behind naming it as environment_type? Should it just be environment or base_url? In my opinion, this should not be a required parameter, rather it should default to production. https://registry.terraform.io/providers/n3integration/godaddy/latest/docs. Please confirm what the API actually defaults to.
  2. I feel that the secret_key argument should be renamed to api_secret as per the sample mentioned below -
    
    Calling the API
    Here is a sample call using the API to check if a domain is available. Replace API_KEY and API_SECRETwith your API Key and Secret.

curl -X GET -H "Authorization: sso-key [API_KEY]:[API_SECRET]" "https://api.godaddy.com/v1/domains/available?domain=example.guru"

ParthaI commented 1 year ago

What is the reason behind naming it as environment_type? Should it just be environment or base_url? In my opinion, this should not be a required parameter, rather it should default to production. https://registry.terraform.io/providers/n3integration/godaddy/latest/docs. Please confirm what the API actually defaults to.

The GoDaddy SDK which is being used here, it is passing the base URL internally as per the type of GoDaddy environment we have weather we have a Production/Development environment.

I feel that the secret_key argument should be renamed to api_secret as per the sample mentioned below

Updated the argument secret_key to api_secret

ParthaI commented 1 year ago

@ParthaI please take a look at the review comments. Thanks!!

Additional questions: