search

turbot / steampipe-plugin-net

Use SQL to instantly query DNS records, certificates and other network information. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/net
Apache License 2.0
23 stars 5 forks source link

net_certificate queries completely fail when one or more hosts don't exist in DNS #47

Closed bdd4329 closed 2 years ago

bdd4329 commented 2 years ago

Describe the bug net_certificate queries completely fail when one of the hosts queried don't exist in DNS

Steampipe version (steampipe -v) v0.16.1

Plugin version (steampipe plugin list) v0.7.0

To reproduce Run a query with at least one host that doesn't have a DNS entry: echo "select * from net_certificate where domain in ('www.google.com', 'nodnsforthis.site');" | steampipe query Warning: executeQueries: query 1 of 1 failed: ERROR: rpc error: code = Unknown desc = TLS connection failed: dial tcp: lookup nodnsforthis.site on 128.194.254.1:53: no such host (SQLSTATE HV000)

Expected behavior Just like when no service exists on port 443, the host should be ignored, and the rest of the query should complete.

Additional context None

bdd4329 commented 2 years ago

Submitted #49 to fix this issue. I am not a Golang programmer, but I made an attempt to fix this issue.

misraved commented 2 years ago

Closed per https://github.com/turbot/steampipe-plugin-net/pull/49