Add a field to the net_certificate table to specify a port

turbot / steampipe-plugin-net

Use SQL to instantly query DNS records, certificates and other network information. Open source CLI. No DB required.

https://hub.steampipe.io/plugins/turbot/net

Apache License 2.0

23 stars 5 forks source link

Add a field to the net_certificate table to specify a port #48

Closed bdd4329 closed 1 year ago

bdd4329 commented 2 years ago

Is your feature request related to a problem? Please describe. I would like to be able to monitor certificate expiration dates on other commonly used TLS ports such as 636, 8443, etc. Using an alternative product to monitor other ports means that I can't easily have a single dashboard for all of my certs if I want to use Steampipe.

Describe the solution you'd like "port" should be added as a field to the net_certificate table, which would enable certificates on arbitrary ports to be monitored. I assume that it's not there right now so that it doesn't need to be specified for most cases.

Describe alternatives you've considered Use an alternative product to monitor these ports.

Additional context None

github-actions[bot] commented 2 years ago

'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.'

bdd4329 commented 2 years ago

I can see that @cbruno10 added a PR for this issue (#50). Is there some reason why his PR hasn't been approved?

cbruno10 commented 2 years ago

Hi @bdd4329 , for that PR, I had started work on it, but then had a thought that instead of just adding port, what if instead we added a new column that would take a full address, including the port (similar to other tables in this plugin), and deprecate the current domain column.

I was assessing the impact of this change on the table + mods that use, like the Net Insights Mod, and then unfortunately got distracted with some other priorities.

I'll take another look at the PR and its impact again this week, but in the meantime @bdd4329 , if this is a blocker for you, feel free to locally compile the add-certificate-port branch and see if the new address column helps with your requirements.

bdd4329 commented 2 years ago

@cbruno10. I don't have any problem with waiting another week. I responded because I saw that the "stale" label had been placed on the issue, and I didn't want it to be closed.