turbot / steampipe-plugin-oci

Use SQL to instantly query Oracle Cloud resources across regions and accounts. Open source CLI. No DB required.
https://hub.steampipe.io/plugins/turbot/oci
Apache License 2.0
18 stars 5 forks source link

Missing schema name for oci_database_db #589

Closed hslange closed 8 months ago

hslange commented 8 months ago

Describe the bug The table oci_databae_db is missing a schema/column: database_management_config. This column provides information if OCI Database Management is enabled or not for this database and if so, what the state is.

Steampipe version (steampipe -v) v0.21.2

Plugin version (steampipe plugin list) 0.33.0

To reproduce Column is not available in the table, however it's described in the documentation: OCI API reference

Expected behavior For each database, this column should show the status of the Management options for the database. Possible values:

Additional context This column will provide more information about databases regarding OCI Database Management. This can be added to the OCI Insights mod to show:

ParthaI commented 8 months ago

Hello @hslange,

Thank you for highlighting this issue. Your engagement with Steampipe is truly valued.

To address the matter you've raised, we've initiated a draft PR, which incorporates all the columns that were previously missing in the table.

We would be grateful if you could test this out on the PR branch (issue-589) and share your feedback with us.

Here are the steps to try out the changes in the issue-589 branch:

  1. Clone the repository: git clone https://github.com/turbot/steampipe-plugin-oci.git
  2. Navigate to the directory: cd steampipe-plugin-oci
  3. Switch to the branch: git checkout issue-589
  4. Execute the command: make
  5. Run your query

Thank you!

hslange commented 8 months ago

Hi @ParthaI , Thank you very much for the quick implementation. I tested it and it's working as expected. results of a query to retrieve the database_management_options returns either:

Please go ahead and push for PR. Thanks again, Herman

ParthaI commented 8 months ago

Hello @hslange, Thank you for thoroughly testing the PR and sharing your feedback on the changes. Your input is highly valued! I'll coordinate with our team to determine our subsequent actions. 👍