turbot / steampipe

Zero-ETL, infinite possibilities. Live query APIs, code & more with SQL. No DB required.
https://steampipe.io
GNU Affero General Public License v3.0
6.84k stars 264 forks source link

if `--progress=false`, the snapshot URL is suppressed #2954

Closed jchrisfarris closed 1 year ago

jchrisfarris commented 1 year ago

Describe the bug When using --snapshot with --progress=false the URL of the snapshot is not returned.

Steampipe version (steampipe -v) 0.17.4

To reproduce

steampipe check all --snapshot-location jcfarris/fooli --snapshot --progress=false 

The snapshot is uploaded, however the Snapshot uploaded to line is not output.

Expected behavior The output of the snapshot is probably not really progress like the initialization block that comes before the check output.

Additional context Testing was done in the context of the steampipe-mod-terraform-aws-compliance

jchrisfarris commented 1 year ago

Also, I noticed when using --output json the Snapshot uploaded to line is just appended to the json file making it invalid json.

kaidaguerre commented 1 year ago
When using --snapshot with --progress=false the URL of the snapshot is not returned.

I believe this was a deliberate design decision, will confirm/discuss

kaidaguerre commented 1 year ago

Also, I noticed when using --output json the Snapshot uploaded to line is just appended to the json file making it invalid json.

So, if you want valid json in a file you could use --export:

steampipe check all --snapshot-location jcfarris/fooli --snapshot  --export json 

or set progress=false:

steampipe check all --snapshot-location jcfarris/fooli --snapshot --progress=false --output json > output.json
kaidaguerre commented 1 year ago
I believe this was a deliberate design decision, will confirm/discuss

confirmed - closing this