Panel names for arbitrary query snapshots should not contain the mod name

turbot / steampipe

Zero-ETL, infinite possibilities. Live query APIs, code & more with SQL. No DB required.

https://steampipe.io

GNU Affero General Public License v3.0

6.84k stars 264 forks source link

Panel names for arbitrary query snapshots should not contain the mod name #3150

Closed MichaelBurgess closed 1 year ago

MichaelBurgess commented 1 year ago

If I run the following inside a mod directory, where the mod title is stuff:

steampipe query "select foo from bar;" --output sps

...the panel names are stuff.dashboard.command_line_query and stuff.table.command_line_query for the dashboard and table panels respectively.

We should not use the mod name in the panel name, as this query is not tied to this mod unlike a named query.

MichaelBurgess commented 1 year ago

@johnsmyth / @e-gineer we need to decide the correct naming approach here.

If you're not in a mod we do:

local.dashboard.command_line_query
local.table.command_line_query

MichaelBurgess commented 1 year ago

@kaidaguerre I've also found a bug / inconsistency in the generated query snapshot.

The dashboard panel name is <mod_name>.dashboard.command_line_query, but the 2 panels both have a dashboard name of <mod_name>.query.command_line_query.