Installation inconsistency when specifying a Git tag

[electriquo]

Describe the bug When specifying the (Git) tag, e.g. v0.104.0, the installation fails. Where this is not the case when using the same tag without the v prefix, e.g. 0.104.0.

This cause many update managers that track Git for new tags and updates Steampipe accordingly.

Steampipe version (steampipe -v)

$ steampipe --version
Steampipe v0.20.5

To reproduce

$ steampipe plugin install aws@v0.104.0

aws@v0.104.0                   [====================================================================] Not found

Skipped the following plugin:

Plugin:   aws@v0.104.0
Reason:   Not found

$ steampipe plugin install aws@0.104.0

aws@0.104.0                    [====================================================================] Done

Installed plugin: aws@0.104.0 v0.104.0
Documentation:    https://hub.steampipe.io/plugins/turbot/aws

Expected behavior Both steampipe plugin install aws@v0.104.0 and steampipe plugin install aws@0.104.0 should install the plugin without any errors.

Additional context The issue results in inconsistent experience through Steampipe, since this is not the case for modules

$ steampipe mod install github.com/turbot/steampipe-mod-aws-insights@v0.12.0

Installed 1 mod:

local
└── github.com/turbot/steampipe-mod-aws-insights@v0.12.0

[misraved]

Apologies for the inconvenience @foolioo.

As per the steampipe install command, steampipe plugin install aws@0.104.0 is actually the correct way of installing a new version of the plugin.

https://hub.steampipe.io/plugins/turbot/aws/versions

@cbruno10 @johnsmyth could you echo some thoughts on whether steampipe plugin install aws@v0.104.0 should be made valid or not?

[electriquo]

@misraved Apologies are unnecessary, I thank all of you for your work. The v prefix is common and is already used in all of turbot codebaes, why not to honer it same as all other open source projects? Plus, it makes all other update tools, e.g. Dependabot, play nicely with Steampipe.

Please consider aligning the version and accept installations that correspond to Git tag, e.g. v0.104.0

[johnsmyth]

This seems reasonable, since the mod install accepts either form. Moving this issue to the steampipe repo...

[kaidaguerre]

I agree, seems reasonable to be forgiving about the formats we accept. We'll take a look

[electriquo]

@johnsmyth For me to follow the issue, what exactly did you mean by

Moving this issue to the steampipe repo...

[johnsmyth]

@foolioo originally the issue was raised in the aws plugin repository (turbot/steampipe-plugin-aws ), but the fix is a general steampipe fix, so I moved the issue to the steampipe (turbot/steampipe) because thats where the code is that will need to be updated.

[electriquo]

I agree, seems reasonable to be forgiving about the formats we accept. We'll take a look

@kaidaguerre Is there any update?

[kaidaguerre]

@kaidaguerre Is there any update?

Not yet I'm afraid - it's on our list but we have not got to it yet.

[electriquo]

@kaidaguerre Apologies for putting "stress" on to it and thank all of you for your work. Since this should be an "easy" fix which will let all dependency update pipelines (such as Dependabot) to pass and enjoy new versions of steampipe its modules and plugins.