turbot / steampipe

Zero-ETL, infinite possibilities. Live query APIs, code & more with SQL. No DB required.
https://steampipe.io
GNU Affero General Public License v3.0
7.02k stars 278 forks source link

Including an unsupported scope in a limiter's `scopes` causes rate limiter to not be applied #4099

Open cbruno10 opened 10 months ago

cbruno10 commented 10 months ago

Describe the bug If I add a limiter:

plugin "aws" {
  limiter "s3_limiter" {
    bucket_size = 50
    fill_rate   = 50
    scope       = ["connection", "service", "foo"]
    where       = "service = 's3'"
  }
}

Even if the tags are correct for the S3 tables, no rate limiters are applied due to the foo scope.

Similarly, if I add region, which is a valid scope for other tables, but not aws_s3_bucket, limiters won't be applied.

Steampipe version (steampipe -v) v0.21.4

To reproduce Add the limiter above and run this query to check if rate limiters are applied:

select jsonb_pretty(_ctx) from aws_s3_bucket limit 1

Expected behavior An error should be raised letting me know that there's an invalid scope

Additional context Add any other context about the problem here.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 7 months ago

This issue was closed because it has been stalled for 90 days with no activity.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 90 days with no activity.

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.