search

turbowookie / turbo-wookie

Turbo Wookie Project. Because Turbo Wookie
http://turbowookie.github.io
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Album Art is GIGANTIC #13

Closed sleepdeprecation closed 10 years ago

sleepdeprecation commented 10 years ago

The "natural" size of some of the album artwork being grabbed from last.fm is occasionally gigantic (as in 1024x1024). Maybe you could just check that it's >= 300px ?

Mostly because it just took ~30 seconds to download one of the pictures, and we don't even see that fine a detail...

mpeterson2 commented 10 years ago

If we can do this with just a link to the album then we can. I'm not really sure if that's possible though?

mpeterson2 commented 10 years ago

If you can't do this without downloading the image, we may get an image size in the json data. I'll look into this later tonight or tomorrow.

sleepdeprecation commented 10 years ago

I thought you had some means of making sure the image wasn't too small. I recall reading a comment to that effect, but I may be remembering wrong.

mpeterson2 commented 10 years ago

No not really... Also another issue, I just pulled and I'm getting a 404 when I try to view index.html.

mpeterson2 commented 10 years ago

Also on /songs, it's having a problem opening my files...

sleepdeprecation commented 10 years ago

Are the not MP3s? Because that's going to cause a problem right now...

I'm working on a different problem right now (having the server auto add a random song when the queue is empty), but I can look at that one soon.

mpeterson2 commented 10 years ago

They are MP3s. I didn't change anything sense it worked last time I messed with this. Also I made an issue.

mpeterson2 commented 10 years ago

So we get back a size. We get small, medium, large, extralarge, and mega.

And I've had some small images that are 30px and others that are 180, so it's pretty unreliable. Right now, we are selecting mega which one of my albums are 700px for that. extralarge is 300px, large is 174px, and that's already too small for our sidebar. Even smaller, medium is 64px, and small is 32px.

We could request a smaller image, but we don't want to give the user a terrible pixelated image. I kinda think we should just play it safe because it really shouldn't take 30 seconds to load album art of just over 1000x1000px. I think that was just a once in a while thing that we can live with.

What do you think?

sleepdeprecation commented 10 years ago

extralarge sounds fine. Isn't our sidebar 300? Plus, even if it's a little too small right now, it doesn't matter for demo day.

mpeterson2 commented 10 years ago

Our sidebar is 268 actually, and this was all just for one image. last.fm can be pretty random when it comes to sizes. Anyway I'll lower it to extralarge and we can decide with time.