turbowookie / turbo-wookie

Turbo Wookie Project. Because Turbo Wookie
http://turbowookie.github.io
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Thumb state changes when the playlist updates #16

Closed sleepdeprecation closed 10 years ago

sleepdeprecation commented 10 years ago

The thumbs (up and down) get reverted to their unclicked state when the playlist changes.

I have no idea if this is something that could work, but you might be able to add a unique id (like playlist pos + filepath, replacing non alphanumeric chars with a placeholder ?), and reorder them if needed.


On a related note, something I thought would be kinda cool would be having the previously played songs still in the list, but above the current song.

If you put each track's artwork in their div, even if it's not the current one, you wouldn't even need to change the markup other than to add a "current" or "previous" class to the current song or previous songs. All the visual changes could just be CSS.

Just an interesting side thought...

mpeterson2 commented 10 years ago

This has been resolved by hiding the fact that we have thumb buttons until we actually create voting.

sleepdeprecation commented 10 years ago

Good choice?

Don Kuntz http://don.kuntz.co | don@kuntz.co

On Wed, Dec 4, 2013 at 4:47 PM, Michael Peterson notifications@github.comwrote:

This has been resolved by hiding the fact that we have thumb buttons until we actually create voting.

— Reply to this email directly or view it on GitHubhttps://github.com/dkuntz2/turbo-wookie/issues/16#issuecomment-29854070 .