search

turbowookie / turbo-wookie

Turbo Wookie Project. Because Turbo Wookie
http://turbowookie.github.io
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Albums with weird names apparently don't have any songs. #26

Closed mpeterson2 closed 10 years ago

mpeterson2 commented 10 years ago

An example is 30 Seconds To Mar's album Love Lust Faith + Dreams. For some reason when you search for that in mpc's find function, nothing is returned to the client.

It also doesn't work with &'s and probably other weird things.

If you telnet into localhost 6600 and type:

find artist "30 Seconds To Mars" album "Love Lust Faith + Dreams"

It actually does find all the files, but it's not returned to the client. I'm assuming that our album's name is getting encoded to be able to get sent to our server.

mpeterson2 commented 10 years ago

So I believe it is being encoded because by the time it gets to the server, the album's name is Love Lust Faith Dreams (note the three spaces in between Faith and Dreams instead of two spaces and a +)

mpeterson2 commented 10 years ago

With an &, it just gets cut off at the &.

So B-sides & Rarities becomes B-sides.

sleepdeprecation commented 10 years ago

The ampersand kills it because key/value pairs are separated by &s. To fix it, we'd need to URL encode and URL decode (or really, any kind of encode/decode pair) when sending it back.

mpeterson2 commented 10 years ago

Yeah, I'm just hoping there's an easy way to do this between Dart and Go.

sleepdeprecation commented 10 years ago

URL encoding. Hopefully. It's a standard...

mpeterson2 commented 10 years ago

Yeah that's what I'm a bit worried about. It should be standard though.

mpeterson2 commented 10 years ago

On a side note, this is probably also why last.fm doesn't give me the album art for that album.

mpeterson2 commented 10 years ago

Fixed with commit 694202b7d14d8bb6b833489885097a23e0edb6d0