search

turbowookie / turbo-wookie

Turbo Wookie Project. Because Turbo Wookie
http://turbowookie.github.io
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Search broke. #27

Open sleepdeprecation opened 10 years ago

sleepdeprecation commented 10 years ago

Search doesn't work. That's all.

mpeterson2 commented 10 years ago

So it's not 100% broken.

Just to write down some more info about this:

It only searches what is currently in the songs table. So if there is nothing there, there's nothing to filter. Seeing as we don't have all of songs in memory anymore, unless you're on the songs tab, we will have to ask the server to search for songs.

sleepdeprecation commented 10 years ago

So ... search should just always ask the server (if/when we get that setup)?

mpeterson2 commented 10 years ago

Probably. The only situation where we won't have to ask the server is when we're on the songs tab.

sleepdeprecation commented 10 years ago

I don't think that's true.

I'd much rather do a global search than a scoped search regardless of where I am. For larger libraries especially. Unless you mean "only when you choose to display all songs in your library in list form". In which case, I agree...

Don Kuntz http://don.kuntz.co | don@kuntz.co

On Wed, Dec 18, 2013 at 6:17 PM, Michael Peterson notifications@github.comwrote:

Probably. The only situation where we won't have to ask the server is when we're on the songs tab.

— Reply to this email directly or view it on GitHubhttps://github.com/turbowookie/turbo-wookie/issues/27#issuecomment-30894768 .

mpeterson2 commented 10 years ago

Yeah that's what I meant. The songs tab, where ALL the songs are listed.

mpeterson2 commented 10 years ago

We could also show different sections for our searches now. Kinda like how Google Music does their searches. We should be able show a section for aritsts, albums, and songs.

sleepdeprecation commented 10 years ago

I had the same thoughts.

On Wednesday, December 18, 2013, Michael Peterson wrote:

We could also show different sections for our searches now. Kinda like how Google Music does their searches. We should be able show a section for aritsts, albums, and songs.

— Reply to this email directly or view it on GitHubhttps://github.com/turbowookie/turbo-wookie/issues/27#issuecomment-30897378 .

Don Kuntz http://don.kuntz.co | don@kuntz.co

mpeterson2 commented 10 years ago

So MPD has a search and find command, so we can probably use this to make it easy.