search

turdusmerula / kipartman

Kicad parts manager and BOM extension tool
GNU General Public License v3.0
6 stars 2 forks source link

[BUG] Octopart lookup occasionally throws "List Index out of Range ?" error #22

Open auphofBSF opened 6 years ago

auphofBSF commented 6 years ago

OctopartExtractor Method GetUnits catching error for unit not in kipartbase. A TODO: is marked in code to create unit if not found.

Commit https://github.com/turdusmerula/kipartman/commit/f7cc0133b0b164fdea1c00c0d3bd368e145df3b8 improves the warning/error displayed and updates todo

Does the Api need extending with a add_unit method ?, Will this be a Swagger spec to be created ?

Additionally

  1. the UnitPrefix should have the same treatmentent
  2. Modal Error messages should possibly be directed to logging ( this is probably through out codebase)
  3. If Errors in Octopart Lookup happen, should they be added to the part comment field ?
turdusmerula commented 6 years ago

To be honest for those TODO I have not yet taken the time to have a good conception so this part remains with a nasty error handling. I don't yet know what is the best strategy, maybe asking the user what needs to be done could be a good solution? But yes modal messages are not very handy

auphofBSF commented 6 years ago

The functionality of what Kipartman provides as a basis, is very good. There will always be TODO's and good design is only achieved by best engineering available and recognizing that exploration (iteration) is just a part of that. The functionality that Kipartman has at the moment, is quiet unique and it has a strong base for exploring further functionality

From a component/part in a Design Data Management system I feel I want something like in GIT, trace-ability.

Not saying everything needs to be like Git but it does provide a mature and detailed example.

So I feel if most Modal messages either ended up going to a logfile and possibly extracts of that log are listed with the component/parts comment field or alternatively a Log field that is indelible. What do you think, one can always cancel or requery.

I will be away for a couple of days with family Xmas activities. I wish you a happy XMAS and look forward to enhancing Kipartman with you through 2018. Its a great tool

turdusmerula commented 6 years ago

I'm in holidays too with family, hope you had a merry Christmas :)

I'm still thinking for a right version configuration management system for models and footprints, design in progress !