search

turdusmerula / kipartman

Kicad parts manager and BOM extension tool
GNU General Public License v3.0
6 stars 2 forks source link

[BUG?] PARTS, Drag and Drop functionality not working smoothly #8

Closed auphofBSF closed 6 years ago

auphofBSF commented 6 years ago

Dragging part over category items (Left pane) indicates no options image

However dragged to the top of frame displays + on the floating tooltip and then usually drags into the top most displayed category but not always image

Trying to debug various other issues with Drag and Drop . I have some patches that improve error handling and debugging I will publish as pull requests, but as yet no solution.

auphofBSF commented 6 years ago

added a pull request https://github.com/turdusmerula/kipartman/pull/9 Issue#8 parts dragand drop

This has some error fixes and additional debugging support via logging

turdusmerula commented 6 years ago

Great ! It was part of the TODO list inside tree.py. Did you managed to have a proper cursor handling on Windows for accepted/rejected drop targets? If yes, it doesn't seems to work very well on Linux, we may have to implement platform specific handling for this part.

I corrected the problem that occurred when dropping a part to itself on #7 and improved backend error reporting (we still had a 200 response when an error was detected, now we have a 403).

auphofBSF commented 6 years ago

I have only managed to clear up some of the code crashing issues, with the last pull request #9

I still cannot drag a part on to a category dataview line item. At present on windows all treecategories lines are showing rejected only the outside frame (Header row) accepts drops where but Cursor is showing as acopy not move.
I am not familiar with wxPython so trying to get my head around it with some test code.

turdusmerula commented 6 years ago

This problem looks specific either to Windows or to wxPython version. I have it working on Linux with wxPython 4.0.0b2, I will have to take some time to create a testing environment with a kicad compatible version for further testing.

auphofBSF commented 6 years ago

I have temporarily disabled the requirement for pcbnew so am testing against both wxPython 3 and 4 om MSW10 . I will try tomorrow on a ubuntu 16 Virtualbox instance.

auphofBSF commented 6 years ago

Finally some success, with DnD. However the changes in tree.py might only suite MSW. I will need to check these changes in a linux enviroment. Until they are checked I will not issue a Pull request, and leave the changes in the branch created issue#8-FIXTEST. Nice work @turdusmerula on the parts parameters display/filtering/flattening, #5 and #3 have not looked in detail but will be very useful.

turdusmerula commented 6 years ago

If the merge is okay for MSW we can close this bug, I haven't seen any problem on Ubuntu.

auphofBSF commented 6 years ago

Very Happy to close, drag and drop functionally working also tested in foot print tree