search

turicas / rows

A common, beautiful interface to tabular data, no matter the format
GNU Lesser General Public License v3.0
869 stars 134 forks source link

Fixes issue #286 "Text plugin is not working on `rows convert`" #287

Closed jsbueno closed 6 years ago

jsbueno commented 6 years ago

It was actually a subtle bug , that would only affect the text import plug-in if no text export had already been used on the same process.

The existing tests would not catch it: the values() on the defaultdict containing the characters used for the ASCII frame where always "warmed up" to contain all valid values, before the text import tests where run.

(The actual fix is far simpler than the changes the text to detect the condition if it ever happens again).

Also, this enables the --frame-style option on the "print" command - its availability only on the query command was actually a bug.

jsbueno commented 6 years ago

(And yes, I have retested with auto-tests and manual tests all frame styles for import and export - the issue reported was the only failure case: "classic" ASCII frames would not be detected correctly.)

jsbueno commented 6 years ago

Hi - I just rebased and updated the file - tests are passing here,

turicas commented 6 years ago

I've rebased your branch so we don't have the merge commits in the new branch and then merged into develop. The issue was fixed on f61cdfb6ba5d4e8d2ee1ea961e36f70927079b35. Thanks!