search

turicas / rows

A common, beautiful interface to tabular data, no matter the format
GNU Lesser General Public License v3.0
865 stars 136 forks source link

Feature/decrease xlsx reading time #296

Closed israelst closed 5 years ago

israelst commented 5 years ago

It solves #294

israelst commented 5 years ago

rows use a 0-based index system (so import_from_xlsx(..., start_column=2) would start in the third column, not the second) and openpyxl uses a 1-based index system. I think it will be more accurate and legible if we just convert min/max rows/cols to 1-based system and do not use row/col offset - the (deleted) lines 71-76 did exactly this. What do you think?

Isn't the offset explicit enough? I guess that is the openpyxl way of solving the index issue.

turicas commented 5 years ago

Fixed on a62f2da2afecc42af8ae30664378e8aec7fa1e66.