search

turicas / rows

A common, beautiful interface to tabular data, no matter the format
GNU Lesser General Public License v3.0
869 stars 134 forks source link

New release on pypi #368

Open alexis-via opened 1 year ago

alexis-via commented 1 year ago

I started using the "rows" lib today, and I've lost several hours of work because of a bug on empty cells in ods input. Here is my story.

I was learning/discovering the "rows" lib with an ODS file, and I fall across a strange behavior. Of course, I thought it was because I didn't use the lib properly : so I tried all possible options, searched on the Internet... etc. After several hours, I eventually tried the same code with an equivalent XLSX file and I found out that the behavior was different ! So I realized that I had found a bug on my first day of use of the rows lib !

I decided that I should report the bug. I took the time to write a script to illustrate my bug report. I was using rows 0.4.1 from pypi, but, before creating the bug report on github, I thought I should check if the bug is still present in the "develop" branch... and my script shows that the bug is fixed in the "develop" branch !

Release 0.4.1 is dated Feb 14, 2019... almost 4 years old ! There has been 210 commits since 0.4.1 ; among these 210 commits, I counted about 45 fixes. While counting the commit messages with a fix message, I found the commit that fixes my bug: issue #320 fixed on Match 27 2019 in this commit https://github.com/turicas/rows/commit/c569f9415f2c76b2f6e9afbe1d748946e759711f

So, in December 2022, some users are wasting hours because of a bug that was found and fixed 3,5 years ago :-( No comment !

So, please, push a new release on pypi !

turicas commented 1 year ago

Sorry to hear you had a bad experience. I'm working on updating the changelog so we can finally release the 0.5.0 - which will break Python 2 compatibility (I was locked by this breaking change and decided to go ahead without py2). Hope to push to PyPI next few days. By now, you can install the current version by:

pip install https://github.com/turicas/rows/archive/develop.zip
alexis-via commented 1 year ago

@turicas Great to hear that you're planning a new release in the short term. I'm now running with the code from github, so it works well for me now.

alexis-via commented 1 year ago

Any update about a new release on pypi ?

alexis-via commented 1 year ago

So, what about the release on pypi ?

alexis-via commented 1 year ago

Example of code that I have to write to block users using pypi for rows: https://github.com/akretion/account-move-import/blob/16.0/account_move_csv_import/wizard/account_move_import.py#L477

a-detiste commented 9 months ago

break Python 2 compatibility

I had to add weird patches to Debian vendoring some parts of old unicodecsv, I'd like to clean this up some day.

alexis-via commented 8 months ago

@turicas Do you still plan to make a release on pypi some day, or did you choose to continue without releasing on pypi ?