turing-machines / BMC-Firmware

Turing-pi BMC firmware
http://turingpi.com
GNU General Public License v2.0
228 stars 29 forks source link

Opt out CRC checking on file transfers #154

Closed svenrademakers closed 10 months ago

svenrademakers commented 10 months ago

Is your feature request related to a problem? Please describe. A CRC readback is the last step of writing an OS image to a node. This verification step checks no data corruption happened during transferring and writing. The biggest downside of having this step is the execution time. It adds 30%-50% of extra time to the transfer.

Describe the solution you'd like We generally want to ensure that a given image is written correctly to the nodes. But there are scenarios where there are other faster ways to verify the integrity of the written image. Therefore, an option to opt out of CRC checking is desired. This option could be presented in the UI as a checkbox on the flash node tab.

Describe alternatives you've considered na

Additional context This option should be available both in the tpi tool as in the BMC-UI

svenrademakers commented 10 months ago

fixed by https://github.com/turing-machines/bmcd/commit/2e33575b94722da4ef1fea3493234772c6615821