turing-tech / MaterialScrollBar

An Android library that brings the Material Design 5.1 sidebar to pre-5.1 devices.
Apache License 2.0
778 stars 126 forks source link

Not compatible with the BottomAppBar's hideOnScroll. #128

Open khecha opened 5 years ago

khecha commented 5 years ago

When I scroll using the DragScroll, the BottomAppBar does not auto hide or show, like so:

https://cdn-images-1.medium.com/max/800/1*0uL_CBUwf2yElYVe6wpiig.gif

I tried adding a ScrollListener to the DragScroll, but I did not find another way to hiding the BottomAppBar other than setting it to invisible, which is not optimal since there isn't the animation as seen on the above image.

turing-tech commented 5 years ago

I'll look I to this and get back to you!

turing-tech commented 5 years ago

I see what you're referring to, but I don't know enough about nested scrolling to do anything about it. I'll keep looking into it, but feel free to look into it yourself.

khecha commented 5 years ago

I see what you're referring to, but I don't know enough about nested scrolling to do anything about it. I'll keep looking into it, but feel free to look into it yourself.

I'll have a look when I have some free time! Great library by the way, thanks!