search

turing-tech / MaterialScrollBar

An Android library that brings the Material Design 5.1 sidebar to pre-5.1 devices.
Apache License 2.0
778 stars 126 forks source link

setHandleColour possible collision #13

Closed Tolriq closed 9 years ago

Tolriq commented 9 years ago

A last one for today:)

setHandleColour(int) can lead to unfortunate collision if seeking for a color value that clash with a color resource id.

This is very rare but can happens.

Maybe handle this like other libs : setHandleColour(int color) setHandleColourRes(int colorResid) / setColorResId ?

turing-tech commented 9 years ago

Fixed for upcoming release.

Tolriq commented 9 years ago

Thanks, and good job with the library seems to works well and efficient support ;)