search

turingmachine / omxplayer-sync

OMXPlayer-Sync facilitates synchronization of multiple OMXPlayer instances over the network in a master/slave fashion.
194 stars 70 forks source link

Simple black background command addition ? #58

Closed renoproc closed 6 years ago

renoproc commented 7 years ago

Hi, for my own usage I've added a simple black background command in omxplayer-sync, -b option of omxplayer. A really simple but I think usefull thing. Could it be integrated in the next commit ?

after def run(self): line 137, added p.add_option('--black', '-b', action='store_true')

after self.omxplayer_options.append('--no-osd') line 167, added if self.options.black: self.omxplayer_options.append('-b')

Many thanks !

turingmachine commented 7 years ago

As a matter of fact, omxplayer-sync already passes all options that omxplay-sync doesn't know of to omxplayer. So you could already run omxplayer-sync -b with the current version. Please not that this doesn't work with options that expect an argument.

vanDemonian commented 7 years ago

Thanks. This is great to know. Perhaps it could be added to the read Me?

turingmachine commented 7 years ago

Yes that would be great. Pull requests are welcome!