search

turingschool-projects / lookingForFrontEnd

A job search app built with React
https://looking-for.herokuapp.com/
5 stars 5 forks source link

[WIP] Add refer job button #93

Open Laner12 opened 8 years ago

Laner12 commented 8 years ago

@Automatic365 and I worked to add functionality to refer a friend by clicking a refer friend button then entering an email to send the job listing information to. This is then sent to the backend app using an axios call.

add refer button add email input add submit button add axios post to backend local host

functions worked on were renderRefferButton then from lines 101 - 129

zackforbing commented 8 years ago

this looks pretty solid! I started a review with a couple things we should maybe change before committing.

livecodelife commented 8 years ago

Looks pretty good! As far as your axios post problem I have heard a suggestion updating the state on the promise return. Might look into that

twhitinger commented 8 years ago

I looked through your pull request. You have a lot going on in your JobListItem class. I would consider extracting out the email functionality into its own class and component and keeping the like and unlike functionality in this component. Job List Item doesn't really tell me anything about what this component is doing and you have email and favoriting inside of it so it could be confusing. I think refactoring out the two separate tasks will help you adhere to SRP and for future students working on it. Or not.