search

turingschool-projects / monocle

6 stars 4 forks source link

Company search within distance by zip #35

Closed lsaville closed 7 years ago

lsaville commented 7 years ago

@mscherer11 @Cdunagan05 @alishersadikov This PR: -Finishes the functionality for filtering companies based on a 10 miles radius of a given zip-code. -Includes testing and functionality for unchecking the 'companies within' and having it re-filter when that happens. -Includes validation of the search zip-code (U.S. only) with a message prompting the user to 'Please enter a valid zipcode' if validation failed. -Sets up selenium testing (which we'll have to work out on an individual machine basis because you need to have firefox 41.0 installed installed.

lsaville commented 7 years ago

@Cdunagan05 @mscherer11 @alishersadikov This PR also takes care of dynamic distance selection for choosing the radius around and given zip-code from which to search.

Additionally I reinvigorated a non-functional test 'user_can_filter_company_industry_spec' to use :js => true and got it passing.

Cdunagan05 commented 7 years ago

Looks good. We'll get the testing figured out at a later time.