turingschool / front-end-curriculum

Turing Front-End Engineering Curriculum
http://frontend.turing.io
109 stars 120 forks source link

M2 Testing tdd mocha chai lesson updates #675

Closed hfaerber closed 1 year ago

hfaerber commented 1 year ago

3 PRs on 3 separate repos need review for issue #608

Changes Made in this PR

Requested updates from ticket that were not implemented:

Questions for Reviewer:

netlify[bot] commented 1 year ago

Deploy Preview for sage-cupcake-e1a0c3 ready!

Name Link
Latest commit cc72cbd33a1c758e9fd7d3f06edb9aa334182087
Latest deploy log https://app.netlify.com/sites/sage-cupcake-e1a0c3/deploys/64401f1cff541000088f9347
Deploy Preview https://deploy-preview-675--sage-cupcake-e1a0c3.netlify.app/lessons/module-2/testing-tdd-mocha-and-chai
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

niksseif commented 1 year ago

Hey Heather! Thanks for working on this. I haven't had the chance to review this pull request entirely yet, but I noticed that Netlify is not passing one of your changes. You may want to update the image address from "http://i.imgur.com/T7Q4YkE.png" to "https://i.imgur.com/T7Q4YkE.png".

hfaerber commented 1 year ago

Fixed errors based on Cass's comments. Merging to development.