turingschool / front-end-curriculum

Turing Front-End Engineering Curriculum
http://frontend.turing.io
109 stars 120 forks source link

Fp nik #693

Closed niksseif closed 1 year ago

niksseif commented 1 year ago

This PR is for the React Router V6 - Issue #636 Link to the exercise PR Link to pre-work

Changes Requested in Issue:

Changes Made:

Questions:

After updating the React Router V6 with the new documentation links and improved styling, I noticed that the styling does not appear when running the curriculum server. This issue arises because we do not have this lesson included in the lessons within the index.html file. So, I am wondering whether I need to add it to the HTML file before merging it to the development branch or wait until the merge is complete? NVM - Added this lesson to the index.html file and styling is fixed

I would greatly appreciate your feedback and suggestions regarding any further improvements or adjustments needed for the pull request.

netlify[bot] commented 1 year ago

Deploy Preview for sage-cupcake-e1a0c3 ready!

Name Link
Latest commit c5d0d2079a0c1e6518e160d7f9e7d0310cb915d5
Latest deploy log https://app.netlify.com/sites/sage-cupcake-e1a0c3/deploys/64651890018a6500087cff8c
Deploy Preview https://deploy-preview-693--sage-cupcake-e1a0c3.netlify.app/lessons
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sertmer commented 1 year ago

I think that pre-work is going to make a huge difference. Router is one of those lessons that seems to intimidate the students, but then they quickly get the hang of it. I'm confident that your pre-work will decrease that intimidation factor.