turingschool / turlink-be

0 stars 0 forks source link

Feature/user login #11

Closed noahdurbin closed 1 month ago

noahdurbin commented 1 month ago

Description of Changes

What are the relevant tickets (if any)

Closes #2

Testing

Checklist

Reviewer Instructions

Deployment Notes

jdmchugh111 commented 1 month ago

There's some things I have questions about - I think some of it wasn't new code, just code that was commented back in. Overall looks good, just want to clarify some of the config and bin file adjustments I haven't seen before. Also, I think there should be a fix for allowing cors to work on a different port than 3000. If it's easier we might be able to configure frontend to run their development servers on a different port than 3000, but I'm not sure which is an easier fix

Also, you should update the README documentation with the new endpoints/json contracts when you get the chance so frontend can utilize