Rg/feature/landing page

reesegreen2014 commented 2 months ago

Description of Changes

This PR introduces the initial structure and styling for the header(including navigation bar) footer and landing page. Additionally, it implements React Router with placeholder components for future development.

What are the relevant tickets (if any)

This PR is related to issues #1 #2 #4 #27, and will be closed upon successful merge of this PR request.

Screenshots (if applicable)

Testing

This is a static webpage with minimum functionality - and it does not use any backend data to accomplish the task. Testing will be conducted in a future iteration as more functionality is built into the application.

Checklist

[x] The code follows the project's coding standards.
[x] Unit tests have been added or updated to cover the changes.
[X] Documentation has been updated to reflect the changes (if applicable).
[X] The code compiles without errors.
[X] The changes have been tested locally and pass all relevant tests.
[X] All new and existing tests pass.
[X] The pull request has been reviewed by at least one other contributor.

Reviewer Instructions

Please focus on the implementation of React Router and the initial styling for the header (including nav bar), landing page and footer. Ensure that it matches the provided comp given in Miro. Please also navigate throughout the application by clicking the links within the nav bar, and ensuring the navigation works smoothly.

Deployment Notes

No special deployments instructions are required as part of this PR.

Additional Information

This PR lays the foundation for future development by setting up the main structure of the application. Future PRs will replace the placeholder components located within App with fully developed pages and add additional functionality.

kiewi16 commented 2 months ago

Hi Reese - I reviewed your PR. The styling looks incredible! I confirmed the following:

[x] Link from landing page to dashboard page works as intended
[x] Link from landing page to about page works as intended
[x] Link from landing page to login page works as intended
[x] The user can navigate between the dashboard, about, and login pages
[x] Header styling matches the provided comp
[x] Landing page styling matches the provided comp with the exception of the input and try it button. Zach is working on tickets that will add those elements to the landing page.
[x] Per our slack conversation, I also reviewed your TypeScript in the Footer, Header, and LandingPage components. Your TypeScript looks good!
[x] Per our slack conversation, we will work on hiding the dashboard link until the user has logged in. The functionality requires that you have access to the login component (which I am working on).

QUESTION: should we add a link to the TurLink icon so the user can navigate back to the landing page from the dashboard page, about page, and login page?

QUESTION: should we open a new ticket or keep open an existing ticket for for hiding the dashboard link until the user logs in?

reesegreen2014 commented 2 months ago

Hi @kiewi16 !

Thanks for your questions! To answer them:

QUESTION: should we add a link to the TurLink icon so the user can navigate back to the landing page from the dashboard page, about page, and login page?
- Thanks for calling this out! I will get this added in the next branch I'm working on for the dashboard.
QUESTION: should we open a new ticket or keep open an existing ticket for for hiding the dashboard link until the user logs in?
- I'll open a new ticket to handle hiding the dashboard link, which will be completed after the state is set to manage whether a user is logged in. This will allow us to track the implementation of this logic separately once the necessary state management is in place.

Swatzell commented 2 months ago

Hi Reese - I reviewed your PR. The styling looks incredible! I confirmed the following:

[x] Link from landing page to dashboard page works as intended

[x] Link from landing page to about page works as intended

[x] Link from landing page to login page works as intended

[x] The user can navigate between the dashboard, about, and login pages

[x] Header styling matches the provided comp

[x] Landing page styling matches the provided comp with the exception of the input and try it button. Zach is working on tickets that will add those elements to the landing page.

[x] Per our slack conversation, I also reviewed your TypeScript in the Footer, Header, and LandingPage components. Your TypeScript looks good!

[x] Per our slack conversation, we will work on hiding the dashboard link until the user has logged in. The functionality requires that you have access to the login component (which I am working on).

QUESTION: should we add a link to the TurLink icon so the user can navigate back to the landing page from the dashboard page, about page, and login page?

QUESTION: should we open a new ticket or keep open an existing ticket for for hiding the dashboard link until the user logs in?

Hi @kiewi16 !

Thanks for your questions! To answer them:

QUESTION: should we add a link to the TurLink icon so the user can navigate back to the landing page from the dashboard page, about page, and login page?

Thanks for calling this out! I will get this added in the next branch I'm working on for the dashboard.

QUESTION: should we open a new ticket or keep open an existing ticket for for hiding the dashboard link until the user logs in?

I'll open a new ticket to handle hiding the dashboard link, which will be completed after the state is set to manage whether a user is logged in. This will allow us to track the implementation of this logic separately once the necessary state management is in place.

That all sounds great to me! Everything looks good i'm going to approve and merge!

turingschool / turlink-fe