turingschool / turlink-fe

2 stars 0 forks source link

Rg/feature/dashboard layout #36

Closed reesegreen2014 closed 2 weeks ago

reesegreen2014 commented 3 weeks ago

Description of Changes

This PR introduces key updates to the dashboard and navigation functionality. These changes include:

What are the relevant tickets (if any)

Screenshots (if applicable)

image image image

Testing

User testing has been conducted to ensure the navigation works as behaved, including conditional rendering based on authentication state. Further testing will be conducted in Cypress in later development.

Checklist

Reviewer Instructions

Please review the changes, particularly relating to the header conditional rendering based on a user being logged in or logged out, and also check the protected route for the dashboard by attempting to access localhost:3000/dashboard while being logged out to ensure this routes you to the login page.

Deployment Notes

No deployment instructions are required for this PR.

Additional Information

N/A at this time.

kiewi16 commented 3 weeks ago

Hi Reese - nice work on this PR! I confirmed the following and I left one minor comment in the code review.

kiewi16 commented 3 weeks ago

QUESTION - there is a Draft ticket assigned to you under Ready "Landing Page (Hide Dashboard Button)" that I believe should be linked to the PR.

reesegreen2014 commented 2 weeks ago

Question - do we need the console.log on line 64 in Login.tsx?

@kiewi16 Thank you for calling this out! I will remove this in the next branch. I put this in to view the response we were receiving from the backend upon successful login.

QUESTION - there is a Draft ticket assigned to you under Ready "Landing Page (Hide Dashboard Button)" that I believe should be linked to the PR.

Great catch! I have linked it to this PR.

kiewi16 commented 2 weeks ago

Reese - thank you for addressing my comments! I am going to merge this to main.