Closed blackheaven closed 11 months ago
I'm a bit struggling with instances:
Ah yes, that one is really tricky, it took me some time. You need:
import Data.MonadicStreamFunction.Instances.Num ()
I think you're actually bumping the dunai version, and not so much the GHC version, right?
Ah yes, that one is really tricky, it took me some time. You need:
Thank you so much!
I think you're actually bumping the dunai version, and not so much the GHC version, right?
and simple-affine-space
, but that's the only blockers to GHC 9.4 support.
But GHC 9.4 is already supported in rhine
. I think to support 9.6, one needs to bump dunai
, but I'm not sure. The issue with 9.4 is only that the dependency monad-bayes
didn't support 9.4 for a long time. But it does now, I think we just need to enable the CI jobs again.
But to support GHC 9.6, one would also need to make changes to the TestedWith
section in rhine.cabal
, and the CI files. If you want to land a simpler PR, how about just renaming it to "Bump dunai to 0.11", and drop the changed base version constraints?
But GHC 9.4 is already supported in
rhine
. I think to support 9.6, one needs to bumpdunai
, but I'm not sure. The issue with 9.4 is only that the dependencymonad-bayes
didn't support 9.4 for a long time. But it does now, I think we just need to enable the CI jobs again.
I see, when I tried, I have just updated flake.lock
and I have got issues I have attributed to GHC 9.4, which in fact where packages set changes.
I have monad-bayes
on my list, once done, I'll come back to finish the work :)
Can you fix fourmolu and the remaining build errors?
I had a fix, I forgot to push it :/
Is there anything I can do to make the PR move forward?
Sorry, I overlooked that there was already a PR open to fix this in https://github.com/turion/rhine/pull/249 :( It was open since longer and I wasn't sure it would be merged. Thank you anyways!
I'm a bit struggling with instances:
which is weird since:
If anyone can have a look