Remove/refactor Count and FixedRate

turion / rhine

Haskell Functional Reactive Programming framework with type-level clocks

http://hackage.haskell.org/package/rhine

123 stars 21 forks source link

Closed turion closed 6 years ago

turion commented 6 years ago

[ ] FixedRate is against the Rhine philosophy that sample rates should be type-level. There are better alternatives now (Step/FixedStep), and it should be removed.
[ ] Count is just Step 1/FixedStep 1. Should be a type synonym, and moved into the FixedStep module.

SolviQorda commented 6 years ago

Hi again!

I think I have a solution to this, but I'm concerned I may have underestimated the complexity of the issue...

For the first part I understood that to mean delete the module.

For the second part, the following compiles: type Count m cl = FixedStep 1 though I'm concerned that's too simple a solution?

Happy to make a PR if that's easier!

turion commented 6 years ago

Yes, that's the idea, although you don't need those type parameters m and cl.

turion commented 6 years ago

Fixed by @SolviQorda in #84