search

turion / rhine

Haskell Functional Reactive Programming framework with type-level clocks
http://hackage.haskell.org/package/rhine
123 stars 21 forks source link

Eliminate warnings w.r.t. ghc-8.4.3 #95

Closed ggreif closed 6 years ago

ggreif commented 6 years ago

This eliminates all the warnings in rhine/rhine for the 3 GHC versions used in Travis.

turion commented 6 years ago

I'm undecided about unticked promoted constructors. Is there a good reason not to use them? Why does GHC warn about them? I find 'MyConstructor slightly ugly, but if there is a good reason to use it, I will.

ggreif commented 6 years ago

I doubt there is a good reason, sounds like a pedantic thing to me.

On 6/29/18, Manuel Bärenz notifications@github.com wrote:

I'm undecided about unticked promoted constructors. Is there a good reason not to use them? Why does GHC warn about them? I find 'MyConstructor slightly ugly, but if there is a good reason to use it, I will.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/turion/rhine/pull/95#issuecomment-401341047

turion commented 6 years ago

I used ticks in some places like https://github.com/turion/rhine/blob/63fc173d93caea52cd2ec8d969f83ed3fbce433c/rhine/src/FRP/Rhine/Clock/Periodic.hs#L68. Maybe I'll revert that globally to have no ticks anywhere. (Note to self: Ask on IRC what the reasoning is)

turion commented 6 years ago

Thanks!