python AttachedSign doesn't produce correct wire format with empty hidden

turiya / keyczar

Automatically exported from code.google.com/p/keyczar

0 stars 0 forks source link

python AttachedSign doesn't produce correct wire format with empty hidden #120

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Use AttachedSign in python and AttachedVerify in another language.

The problem is with the def PackByteArray(array) in Util.py

`not array` in python would be true with an empty array, and thus PackByteArray 
packs nothing instead of packing a zero length array.

changed to `array is None`

Please provide any additional information below.

fixed in http://code.google.com/r/jtuley-keyczar-python-usekey-exposed/

Original issue reported on code.google.com by jtu...@gmail.com on 23 Jan 2013 at 1:43

GoogleCodeExporter commented 9 years ago

remade commit for easy review:

http://code.google.com/r/jtuley-keyczar-python-usekey-exposed/source/detail?r=e9
a50a423ee0206042e10c2e3a8d7c607a26c87b

Original comment by jtu...@gmail.com on 28 Jan 2013 at 11:40

Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

Original comment by jtu...@gmail.com on 2 Mar 2013 at 8:57

Added labels: Implementation-Python, Type-Patch
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

These links are broken. Here is a fixed link:
https://code.google.com/r/jtuley-keyczar-dev/source/detail?r=e9a50a423ee0206042e
10c2e3a8d7c607a26c87b

This seems like a good fix though.

Original comment by dlundb...@google.com on 26 Jun 2013 at 10:40

Changed state: Accepted
Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

Original comment by dlundb...@google.com on 1 Jul 2013 at 4:49

Changed state: Fixed
Added labels: ****
Removed labels: ****