search

turiya / keyczar

Automatically exported from code.google.com/p/keyczar
0 stars 0 forks source link

Maven build specifies code as 1.5, but code is actually 1.6 #137

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Use of @Override when implementing a Java interface is a 1.6 feature.  It is an 
error in 1.5.  So, the pom.xml should specify code as 1.6; the target can still 
be 1.5.

Patch here:
https://github.com/justinsb/keyczar/compare/fix_java_version.diff

Original issue reported on code.google.com by jus...@fathomdb.com on 12 Aug 2013 at 5:36

GoogleCodeExporter commented 9 years ago 
Here's an immutable version, in case I break my branches:
https://github.com/justinsb/keyczar/commit/e077de8cd09b0dff3212cefd2c26ecdbbc391
102.diff

Original comment by jus...@fathomdb.com on 12 Aug 2013 at 6:57

GoogleCodeExporter commented 9 years ago 
Actually, scratch this one.  On the command-line, maven requires bumping the 
target to 1.6 (though Eclipse figures it out).  Probably reasonable to target 
1.6, but not my call.

Original comment by jus...@fathomdb.com on 12 Aug 2013 at 10:14