🚨 [security] [js] Update express 4.17.2 → 4.19.2 (minor)

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ express (4.17.2 → 4.19.2) · Repo · Changelog

Security Advisories 🚨

🚨 Express.js Open Redirect in malformed URLs

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

0867302
0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

#5539
koajs/koa#1800
https://expressjs.com/en/4x/api.html#res.location

🚨 qs vulnerable to Prototype Pollution

qs before 6.10.3, as used in Express before 4.17.3 and other products, allows attackers to cause a Node process hang for an Express application because an __ proto__ key can be used. In many typical Express use cases, an unauthenticated remote attacker can place the attack payload in the query string of the URL that is used to visit the application, such as a[proto]=b&a[proto]&a[length]=100000000. The fix was backported to qs 6.9.7, 6.8.3, 6.7.3, 6.6.1, 6.5.3, 6.4.1, 6.3.3, and 6.2.4 (and therefore Express 4.17.3, which has "deps: qs@6.9.7" in its release description, is not vulnerable).

Release Notes

4.19.2

What's Changed

Improved fix for open redirect allow list bypass

Full Changelog: 4.19.1...4.19.2

4.19.0

What's Changed

fix typo in release date by @UlisesGascon in #5527

docs: nominating @wesleytodd to be project captian by @wesleytodd in #5511

docs: loosen TC activity rules by @wesleytodd in #5510

Add note on how to update docs for new release by @crandmck in #5541

Prevent open redirect allow list bypass due to encodeurl

Release 4.19.0 by @wesleytodd in #5551

New Contributors

@crandmck made their first contribution in #5541

Full Changelog: 4.18.3...4.19.0

4.18.3

Main Changes

Fix routing requests without method

deps: body-parser@1.20.2

Fix strict json error message on Node.js 19+

deps: content-type@~1.0.5

deps: raw-body@2.5.2

Other Changes

Use https: protocol instead of deprecated git: protocol by @vcsjones in #5032

build: Node.js@16.18 and Node.js@18.12 by @abenhamdine in #5034

ci: update actions/checkout to v3 by @armujahid in #5027

test: remove unused function arguments in params by @raksbisht in #5124

Remove unused originalIndex from acceptParams by @raksbisht in #5119

Fixed typos by @raksbisht in #5117

examples: remove unused params by @raksbisht in #5113

fix: parameter str is not described in JSDoc by @raksbisht in #5130

fix: typos in History.md by @raksbisht in #5131

build : add Node.js@19.7 by @abenhamdine in #5028

test: remove unused function arguments in params by @raksbisht in #5137

use random port in test so it won't fail on already listening by @rluvaton in #5162

tests: use cb() instead of done() by @kristof-low in #5233

examples: remove multipart example by @riddlew in #5195

Update support Node.js@18 in the CI by @UlisesGascon in #5490

Fix favicon-related bug in cookie-sessions example by @DmytroKondrashov in #5414

Release 4.18.3 by @UlisesGascon in #5505

New Contributors

@vcsjones made their first contribution in #5032

@abenhamdine made their first contribution in #5034

@armujahid made their first contribution in #5027

@raksbisht made their first contribution in #5124

@rluvaton made their first contribution in #5162

@kristof-low made their first contribution in #5233

@riddlew made their first contribution in #5195

@DmytroKondrashov made their first contribution in #5414

Full Changelog: 4.18.2...4.18.3

4.18.2

Fix regression routing a large stack in a single route

deps: body-parser@1.20.1

deps: qs@6.11.0

perf: remove unnecessary object clone

deps: qs@6.11.0

4.18.1

Fix hanging on large stack of sync routes

4.18.0

Add "root" option to res.download

Allow options without filename in res.download

Deprecate string and non-integer arguments to res.status

Fix behavior of null/undefined as maxAge in res.cookie

Fix handling very large stacks of sync middleware

Ignore Object.prototype values in settings through app.set/app.get

Invoke default with same arguments as types in res.format

Support proper 205 responses using res.send

Use http-errors for res.format error

deps: body-parser@1.20.0

Fix error message for json parse whitespace in strict

Fix internal error when inflated body exceeds limit

Prevent loss of async hooks context

Prevent hanging when request already read

deps: depd@2.0.0

deps: http-errors@2.0.0

deps: on-finished@2.4.1

deps: qs@6.10.3

deps: raw-body@2.5.1

deps: cookie@0.5.0

Add priority option

Fix expires option to reject invalid dates

deps: depd@2.0.0

Replace internal eval usage with Function constructor

Use instance methods on process to check for listeners

deps: finalhandler@1.2.0

Remove set content headers that break response

deps: on-finished@2.4.1

deps: statuses@2.0.1

deps: on-finished@2.4.1

Prevent loss of async hooks context

deps: qs@6.10.3

deps: send@0.18.0

Fix emitted 416 error missing headers property

Limit the headers removed for 304 response

deps: depd@2.0.0

deps: destroy@1.2.0

deps: http-errors@2.0.0

deps: on-finished@2.4.1

deps: statuses@2.0.1

deps: serve-static@1.15.0

deps: send@0.18.0

deps: statuses@2.0.1

Remove code 306

Rename 425 Unordered Collection to standard 425 Too Early

4.17.3

deps: accepts@~1.3.8

deps: mime-types@~2.1.34

deps: negotiator@0.6.3

deps: body-parser@1.19.2

deps: bytes@3.1.2

deps: qs@6.9.7

deps: raw-body@2.4.3

deps: cookie@0.4.2

deps: qs@6.9.7

Fix handling of __proto__ keys

pref: remove unnecessary regexp for trust proxy

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

turkdevops / electron