search

turkerdev / fastify-type-provider-zod

MIT License
337 stars 21 forks source link

Fix swagger fields being ignored #14

Closed turkerdev closed 2 years ago

kibertoad commented 2 years ago

@turkerdev Does this supersede https://github.com/turkerdev/fastify-type-provider-zod/pull/13?

I would assume we would need to add more type augmentation similarly to how #13 does it, otherwise TS won't compile on the service side.

@andris-sevcenko FYI

kibertoad commented 2 years ago

@turkerdev no hurry, this issue is not a blocker for us, so let's finish discussing after you are properly back :)

kibertoad commented 2 years ago

@turkerdev should we merge it?

turkerdev commented 2 years ago

@kibertoad I forgot to squash the merge, I am not the best GitHub user, can we fix it or should we force push? 😢

kibertoad commented 2 years ago

@turkerdev I would strongly advise against performing manipulations on history after stuff is merged to main already, I don't think it's a big deal that it's not squashed.

kibertoad commented 2 years ago

@turkerdev you can disable all other merge methods and only leave squash in repo settings, to prevent this from happening in the future, btw.

kibertoad commented 2 years ago

it's in the main settings page: image

turkerdev commented 2 years ago

Thank you. I am updating the package to 1.1.4 if everything is OK.

kibertoad commented 2 years ago

Awesome!