Add custom http.Client support

turnage / graw

Golang Reddit API Wrapper

MIT License

288 stars 49 forks source link

Add custom http.Client support #66

Closed tdakkota closed 4 years ago

tdakkota commented 4 years ago

Adds new structScriptConfig, like BotConfig
Adds Client field to BotConfig
Patches clientConfig.Client if it is not nil

CLAassistant commented 4 years ago

All committers have signed the CLA.

turnage commented 4 years ago

You can specify a custom http.Client in this code, but the Transport is overwritten. What in particular do you want to override about the http.Client? Perhaps that would be better to define in the config specifically.

turnage commented 4 years ago

Thank you for writing a PR!

turnage commented 4 years ago

Reverted because this broke users.

Forgive me that I did not catch this in review. Thankfully @iwinulose filed a bug report promptly.

I will re-review if you add tests.

tdakkota commented 4 years ago

Should I make a new PR?

turnage commented 4 years ago

Yes I don’t believe a closed PR can receive updates.