search

turnerlabs / terraform-ecs-fargate

A Terraform template used for provisioning web application stacks on AWS ECS Fargate
Apache License 2.0
425 stars 158 forks source link

fixes for migration to terraform v0.12 #30

Closed BartAlcorn closed 5 years ago

BartAlcorn commented 5 years ago

added variables and removed the square brackets from subnets in ecs.tf due to changes in v0.12 and list.

See: https://www.terraform.io/docs/configuration/functions/split.html

jritsema commented 5 years ago

Thanks for the contribution! Would you mind running terraform fmt to format the code? We also need to test against terraform v0.11 to ensure that the changes are backwards compatible.

jritsema commented 5 years ago

So I tested this against v0.11 and it seemed to work. I tested against v0.12.4 and got the following errors:

Error: Unsupported block type

  on autoscale-perf.tf line 59, in resource "aws_cloudwatch_metric_alarm" "cpu_utilization_high":
  59:   dimensions {

Blocks of type "dimensions" are not expected here. Did you mean to define
argument "dimensions"? If so, use the equals sign to assign it a value.

Error: Unsupported block type

  on autoscale-perf.tf line 77, in resource "aws_cloudwatch_metric_alarm" "cpu_utilization_low":
  77:   dimensions {

Blocks of type "dimensions" are not expected here. Did you mean to define
argument "dimensions"? If so, use the equals sign to assign it a value.
BartAlcorn commented 5 years ago

Crud. The dimensions simply now require an equals between the tag and the value. I’ll fix that and format and re-submit later today.

~ Bart Alcorn On Demand Tools / Compass

From: John Ritsema notifications@github.com Reply-To: turnerlabs/terraform-ecs-fargate reply@reply.github.com Date: Monday, July 15, 2019 at 11:46 AM To: turnerlabs/terraform-ecs-fargate terraform-ecs-fargate@noreply.github.com Cc: "Alcorn, Bart" Bart.Alcorn@turner.com, Author author@noreply.github.com Subject: Re: [turnerlabs/terraform-ecs-fargate] fixes for migration to terraform v0.12 (#30)

So I tested this against v0.11 and it seemed to work. I tested against v0.12.4 and got the following errors:

Error: Unsupported block type

on autoscale-perf.tf line 59, in resource "aws_cloudwatch_metric_alarm" "cpu_utilization_high":

59: dimensions {

Blocks of type "dimensions" are not expected here. Did you mean to define

argument "dimensions"? If so, use the equals sign to assign it a value.

Error: Unsupported block type

on autoscale-perf.tf line 77, in resource "aws_cloudwatch_metric_alarm" "cpu_utilization_low":

77: dimensions {

Blocks of type "dimensions" are not expected here. Did you mean to define

argument "dimensions"? If so, use the equals sign to assign it a value.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_turnerlabs_terraform-2Decs-2Dfargate_pull_30-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAB4O3QJU5GZ4EXLTAK44ELP7SLU3A5CNFSM4ICP2X52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6DP4I-23issuecomment-2D511457265&d=DwMCaQ&c=W8uiIUydLnv14aAum3Oieg&r=y1yVwUx3LWZdtkHmMVmAKonNHdp4FWzPZTiPFQlZwQ8&m=mIQafKTbENhoF9uHefB1kTUH8rD7D102QRl9hpQM4hA&s=3vkNpSw5wKQ5GcUVqZLjQvw3ahMFDrLA3be4LG6N2sc&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAB4O3TSBIQLCFGBKFRITOTP7SLU3ANCNFSM4ICP2X5Q&d=DwMCaQ&c=W8uiIUydLnv14aAum3Oieg&r=y1yVwUx3LWZdtkHmMVmAKonNHdp4FWzPZTiPFQlZwQ8&m=mIQafKTbENhoF9uHefB1kTUH8rD7D102QRl9hpQM4hA&s=KoAsfSzdbqEsPMU_-iRS7jTRB1g21FL9PI4o_2XwCi8&e=.

jritsema commented 5 years ago

So it looks like a version of this template that works with both 0.11 and 0.12 is not going to be possible. I think I'm going to close this in favor of a new PR that that breaks 0.11 and is fully 0.12 compatible.